add: kata #263
Merged
add: kata #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codekow
requested review from
strangiato,
gnunn1,
pittar and
adetalhouet
as code owners
strangiato
requested changes
Nov 13, 2023
| @@ -0,0 +1,10 @@ | |||
| --- | |||
| apiVersion: kustomize.config.k8s.io/v1beta1 | |||
| kind: Kustomization | |||
There was a problem hiding this comment.
Can you move aws and default into an overlays folder?
| @@ -1,8 +1,7 @@ | |||
| --- | |||
| apiVersion: kustomize.config.k8s.io/v1beta1 | |||
| kind: Kustomization | |||
There was a problem hiding this comment.
Was this intended to be inside the base folder?
There was a problem hiding this comment.
I see a little bit better what you are trying to do here. I wonder if this might be a good use for a component instead of putting it in a sub folder in the base?
I have been using components in the gitops instance and it has been a nice we to add some composable features that can be easily consumed by an overlay.
There was a problem hiding this comment.
@strangiato Possible. I saw a few ways to do it. Let's do a working session to decide what will be most elegant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.